On Sun, 23 Feb 2025 05:33:05 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo in java.security documentation > > src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 223: > >> 221: // Handshake signature scope >> 222: public static final Set<SSLCryptoScope> HANDSHAKE_SCOPE = >> 223: >> Collections.unmodifiableSet(EnumSet.of(SSLCryptoScope.HANDSHAKE)); > > I think you get the same with `Set.of(SSLCryptoScope.HANDSHAKE)` Yes, looks that way. I just re-used the collections type that was used before in this code. Actually `Set.of` utilizes stricter `ImmutableCollections` as opposed to current `UnmodifiableCollection`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23681#discussion_r1968109791