On Mon, 24 Feb 2025 18:18:25 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> Yes, looks that way. I just re-used the collections type that was used >> before in this code. Actually `Set.of` utilizes stricter >> `ImmutableCollections` as opposed to current `UnmodifiableCollection`. > > On the 2nd thought: `Set.of` was introduced in 2015, so it's not available in > Java 8, this might be a problem when backporting this code. > @seanjmullan what are your thoughts about this? Something like this is probably ok given it's only jdk8. When many release don't have support, I think it's more of a concern. Additionally these are variable definitions, that are unlikely to change while if a deviation happened in a method, it can get more complex over time. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23681#discussion_r1968442786
