On Wed, 5 Mar 2025 01:02:15 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Clear ServicesMap fields in the declared order
>>
>> Constructors assign the fields in the same order.
>
> src/java.base/share/classes/java/security/Provider.java line 1125:
>
>> 1123: if (oldMi.svc != null) {
>> 1124: // The service exists. Get its Properties map
>> entry. Note:
>> 1125: // Services added through an alias or an attribute
>> may don't
>
> "may don't"? Maybe you mean "may not" or simply "don't"
Good catch. I'd go with "may not" because they have have been added without and
later obtained one.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22613#discussion_r2025618797
