On Sat, 5 Apr 2025 19:12:23 GMT, Valerie Peng <[email protected]> wrote:
>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
>> for the HKDF support from JCA/JCE providers.
>>
>> This is just code refactoring. Known-answer regression test for the internal
>> JSSE HKDF impl is removed as the test vectors are already covered by the
>> HKDF impl in SunJCE provider.
>>
>> Thanks in advance for the review~
>
> Valerie Peng has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added default deriveData method to SSLKeyDerivation interface and
> refactored code to remove unused AlgorithmParameterSpec argument.
src/java.base/share/classes/sun/security/ssl/RSAKeyExchange.java line 295:
> 293:
> 294: @Override
> 295: public SecretKey deriveKey(String type) throws IOException {
How about changing the variable name to `typeNotUsed` like
`SSLKeyDerivation.LegacyMasterKeyDerivation`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24393#discussion_r2031626688
