On Sat, 5 Apr 2025 19:12:23 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
>> for the HKDF support from JCA/JCE providers.
>>
>> This is just code refactoring. Known-answer regression test for the internal
>> JSSE HKDF impl is removed as the test vectors are already covered by the
>> HKDF impl in SunJCE provider.
>>
>> Thanks in advance for the review~
>
> Valerie Peng has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added default deriveData method to SSLKeyDerivation interface and
> refactored code to remove unused AlgorithmParameterSpec argument.
src/java.base/share/classes/sun/security/ssl/SSLKeyDerivation.java line 35:
> 33: SecretKey deriveKey(String purpose) throws IOException;
> 34:
> 35: default byte[] deriveData(String purpose) throws IOException {
This is an internal interface, so I don't think you need to make this a
`default` method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24393#discussion_r2031630692
