On Thu, 1 May 2025 13:51:14 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address review comments from Mark > > test/jdk/sun/security/pkcs11/SecretKeyFactory/TestPBKD.java line 46: > >> 44: * @summary test key derivation on a SunPKCS11 SecretKeyFactory service >> 45: * @library /test/lib .. >> 46: * @modules java.base/com.sun.crypto.provider:open > > This `:open` line is useless now. No more reflection code. Yes, will remove. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24068#discussion_r2070719568