On Wed, 13 Aug 2025 22:50:35 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/.
>> 
>> ![HPKEParameterSpec06-27-3](https://github.com/user-attachments/assets/a17e7ea2-86dd-4e2d-9506-210e97ff8ae8)
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   remove HPKEParameters

src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 402:

> 400:                 ", kdf_id=" + kdf_id +
> 401:                 ", aead_id=" + aead_id +
> 402:                 ", info=" + HexFormat.of().formatHex(info) +

Nit: We can try to convert `info` to UTF-8 string first and print it as a hex 
number only if such conversion fails. Then if we do print it as a hex number we 
should prepend `0x` to it so it's clear what format it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2277054974

Reply via email to