On Thu, 14 Aug 2025 17:46:23 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> In fact, if I output a string format here, I would rather only do it for
>> pure ASCII strings. Some Unicode characters are just not distinguishable
>> from human eyes. Then the check can be very simple.
>>
>> Do you prefer showing both? I mean, info=41424344 ("ABCD").
>
> I see. Yes, ASCII (together with hex) should be fine. We might also change
> `info` encoding from `UTF_8` to `US_ASCII` in tests as well, although it
> should work fine as is since ASCII is a subset of UTF-8. My main concern was
> readability of `info` in tests when we print `HPKEParameterSpec`.
Implemented. Please look at the latest commit.
As for encoding used by `getBytes` in the test, I didn't update it. The whole
`getBytes(...)` was a code-completion inserted by IntelliJ IDEA and I'd rather
respect its choice. :-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2278021885
