On Fri, 15 Aug 2025 00:55:34 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> I see. Yes, ASCII (together with hex) should be fine. We might also change 
>> `info` encoding from `UTF_8` to `US_ASCII` in tests as well, although it 
>> should work fine as is since ASCII is a subset of UTF-8. My main concern was 
>> readability of `info` in tests when we print `HPKEParameterSpec`.
>
> Implemented. Please look at the latest commit.
> 
> As for encoding used by `getBytes` in the test, I didn't update it. The whole 
> `getBytes(...)` was a code-completion inserted by IntelliJ IDEA and I'd 
> rather respect its choice. :-)

Looks good, thanks! I think you misplaced the comments in `bytesToString` 
method though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2279272719

Reply via email to