On Sun, 16 Nov 2025 16:47:29 GMT, Mark Powers <[email protected]> wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - whitespace
>> - address first comments
>
> test/jdk/sun/security/provider/acvp/ML_DSA_Intrinsic_Test.java line 123:
>
>> 121: try {
>> 122: for (int i = 0; i < repeat; i++) {
>> 123: // seed = rnd.nextLong();
>
> 2 lines commented out
This was useful during development and might be useful hint for debugging;
instead of deleting, added a comment. Let me know if that works
> test/jdk/sun/security/provider/acvp/ML_DSA_Intrinsic_Test.java line 517:
>
>> 515: };
>> 516: }
>> 517: // java --add-opens java.base/sun.security.provider=ALL-UNNAMED
>> -XX:+UseDilithiumIntrinsics
>> test/jdk/sun/security/provider/acvp/ML_DSA_Intrinsic_Test.java
>
> This is line is useful. Not sure I would hide it at the bottom of the file.
I actually meant to delete it, but will move it to the top.
> test/micro/org/openjdk/bench/javax/crypto/full/MLDSABench.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights
>> reserved.
>
> Copyright date.
That was some copy-paste! Thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28136#discussion_r2535377021
PR Review Comment: https://git.openjdk.org/jdk/pull/28136#discussion_r2535082275
PR Review Comment: https://git.openjdk.org/jdk/pull/28136#discussion_r2535078538
