On Wed, 19 Nov 2025 21:59:03 GMT, Volodymyr Paprotski <[email protected]>
wrote:
> > What is the reason to add a new microbenchmark? We already have enough
> > micros covering MLDSA:
> > org.openjdk.bench.javax.crypto.full.KeyPairGeneratorBench.MLDSA.generateKeyPair
> > org.openjdk.bench.javax.crypto.full.SignatureBench.MLDSA.sign
> > org.openjdk.bench.javax.crypto.full.SignatureBench.MLDSA.verify
> > org.openjdk.bench.javax.crypto.small.KeyPairGeneratorBench.MLDSA.generateKeyPair
> > org.openjdk.bench.javax.crypto.small.SignatureBench.MLDSA.sign
> > org.openjdk.bench.javax.crypto.small.SignatureBench.MLDSA.verify
>
> I can definitely remove it, got no strong attachment to it.. I did find it
> useful during development and thought it might be useful during review to
> verify performance.. but the usefulness of it beyond is indeed debatable.
>
> You might notice its a lot more 'granular'; it measures the performance of
> the intrinsics themselves, not the ("10-level deep") "wrappers". That said,
> those "wrappers" is what actual user will see and what we should be measuring.
>
> This new benchmark is only useful to another intrinsic developer.. (but it
> should already be usable by other platforms not just Intel?)
I understand your reasons. The question is whether you'll need the
microbenchmark in the future. If no (or probably no), please remove the micro.
If needed, please move it from the "org.openjdk.bench.javax.crypto.full"
package to "org.openjdk.bench.javax.crypto". It is supposed to have only public
API micros in packages "small" and "full"
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28136#issuecomment-3554914771
