On Thu, 20 Nov 2025 23:39:05 GMT, Vladimir Ivanov <[email protected]> wrote:
>>> I understand your reasons. The question is whether you'll need the >>> microbenchmark in the future. If no (or probably no), please remove the >>> micro. If needed, please move it from the >>> "org.openjdk.bench.javax.crypto.full" package to >>> "org.openjdk.bench.javax.crypto". It is supposed to have only public API >>> micros in packages "small" and "full" >> >> @kuksenko I decided to just remove it. If anyone wants it back, its in my >> git history (I usually keep my branches after merge..) > >> If anyone wants it back, its in my git history (I usually keep my branches >> after merge..) > > You could put a comment with the link into JBS issue to make it easier to > discover later. (Or just attach the source file there.) @iwanowww thanks for the suggestion! attached to JBS. @mcpowers would you mind running your internal test suite for this PR? I am thinking of integrating early next week, if no objections; getting close to the release deadline, dont want to cut it even closer.. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28136#issuecomment-3563948572
