On Tue, 18 Nov 2025 15:57:36 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Copyright year updates
>
> src/java.base/share/classes/sun/security/ssl/Alert.java line 241:
>
>> 239:
>> 240: AlertMessage am = new AlertMessage(tc, m);
>> 241: if (SSLLogger.isOn() && SSLLogger.isOn("ssl")) {
>
> Would it make sense to add the calls to the helper methods introduced here
> [JDK-8371721](https://bugs.openjdk.org/browse/JDK-8371721)? I know this is
> not merged yet, but seems like changing it now and later changing it to be
> another method might not be the most efficient way. At least this is how it
> looks to me.
>
> What do you think?
I'm ok to work this one separately. `SSLLogger.logWarning` is customized to
return `boolean ` and is used in 3 SSL classes. Hopefully, that method code is
inlined by JIT for performance.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28376#discussion_r2538885173
