On Tue, 18 Nov 2025 16:18:50 GMT, Daniel Fuchs <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 146:
>>
>>> 144:
>>> 145: public static void severe(String msg, Object... params) {
>>> 146: SSLLogger.doLog(Level.ERROR, msg, params);
>>
>> `log0` might be a better name than `doLog`
>
> Since you have now imported `@ForceInline` maybe you could also add it to
> `doLog` - the methods that call it are all one-liners.
log0 has quite a bit of logic in it. Not sure if it warrants inlining, The
isOn() check will short circuit nearly all log calls in the default JDK
configuration in any case.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28376#discussion_r2538923895
