On Tue, 18 Nov 2025 16:43:40 GMT, Sean Coffey <[email protected]> wrote:
>> test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java line 94:
>>
>>> 92: + System.lineSeparator() +
>>> 93: " \"certificate\" : \\{",
>>> 94: "sun.security.ssl.SSLSocketImpl close",
>>
>> was that change intended? I don't see what it has to do with the rest.
>
> yes - so with the System.Logger in use, we expect to see
> "sun.security.ssl.SSLSocketImpl close" now instead of the old
> "sun.security.ssl.SSLLogger log" calls.
>
> info in JBS report
Oh - OK - makes sense then. The logic of the test was not immediately obvious.
I would have understood if `"sun.security.ssl.SSLSocketImpl close"` had
replaced `"sun.security.ssl.SSLLogger log"`. Now I see that it's adding a
pattern that we expect to additionally find (and previously
`"sun.security.ssl.SSLLogger log"` was not checked) - so that looks good.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28376#discussion_r2539211833
