On Thu, 5 Mar 2026 13:46:13 GMT, Sean Mullan <[email protected]> wrote:

>> src/java.base/share/classes/javax/crypto/spec/DESKeySpec.java line 209:
>> 
>>> 207:      *
>>> 208:      * @param key the buffer with the DES key material.
>>> 209:      * @param offset the offset in <code>key</code>, where the DES key
>> 
>> nit: I know this is obvious, so feel free to ignore it if you think it's 
>> fine. But I would personally mention that the offset should be positive just 
>> in case
>
> I think we should add this error condition to the `InvalidKeyException` text. 
> This will require a CSR.

@seanjmullan I've filed one, let me know if this is what you were looking for.  
Thank you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30069#discussion_r2894204081

Reply via email to