On Thu, 12 Mar 2026 20:42:07 GMT, Shawn Emery <[email protected]> wrote:
>> Thanks, this is looking good. Can you also update the CSR with the latest >> specification changes? > > Thank you for your review. I've updated the CSR according to the new > updates. One subtle change on line 118 of DESedeKeySpec.java where the > original code was throwing an NPE for a method instead of throwing an IKE > similar to all other methods in this class and in DESKeySpec. I think the > distinction is that constructors throw NPE for `null` `key` parameters > whereas methods throw IKE for `null` `key` parameters, no? In this particular API yes, but in general it is more common in other APIs to throw NPE if a parameter should not be null, regardless of whether it is a constructor or method. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30069#discussion_r3195384878
