On Thu, 12 Mar 2026 18:12:28 GMT, Sean Mullan <[email protected]> wrote:
>> Good point on preserving IKE behavior with invalid key length (with offset) >> vs. throwing AIOBE with invalid offsets. I've updated the PR accordingly. >> I believe that we can keep the null key check where they didn't exist before >> because of the following reasons: >> i) preserves existing IKE behavior for this scenario >> ii) good practice to always check and throw exception explicitly before >> dereferencing > > Thanks, this is looking good. Can you also update the CSR with the latest > specification changes? Thank you for your review. I've updated the CSR according to the new updates. One subtle change on line 118 of DESedeKeySpec.java where the original code was throwing an NPE for a method instead of throwing an IKE similar to all other methods in this class and in DESKeySpec. I think the distinction is that constructors throw `NPE` for `null` `key` parameters whereas methods throw IKE for `null` `key` parameters, no? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30069#discussion_r2927262109
