On Mon, 9 Mar 2026 16:41:29 GMT, Weijun Wang <[email protected]> wrote:
> Add export function to HPKE. New tests added. > > Note that this PR does not compile without > https://github.com/openjdk/jdk/pull/18409, even if they are touching > different files. test/jdk/com/sun/crypto/provider/Cipher/HPKE/Compliance.java line 315: > 313: Asserts.assertEquals(16, c1.getBlockSize()); > 314: Asserts.assertEquals(116, c1.getOutputSize(100)); > 315: var c1x = c1.exportKey("AES", new byte[1], 32).getEncoded(); Nit: I'd change it from var to object to make it easier to read. But it's fine as it is if you prefer this way test/jdk/com/sun/crypto/provider/Cipher/HPKE/KAT9180.java line 137: > 135: if (exports != null) { > 136: System.err.print('x'); > 137: var count = 0; What's the reason for keeping the count and printing it? Isn't it going to be easier to debug if just for every loop at first the parameters were logged? Count seems to be just an extra step in debugging ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30146#discussion_r2906789981 PR Review Comment: https://git.openjdk.org/jdk/pull/30146#discussion_r2906763701
