On Mon, 9 Mar 2026 17:07:43 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Add export function to HPKE. New tests added. >> >> Note that this PR does not compile without >> https://github.com/openjdk/jdk/pull/18409, even if they are touching >> different files. > > test/jdk/com/sun/crypto/provider/Cipher/HPKE/Compliance.java line 315: > >> 313: Asserts.assertEquals(16, c1.getBlockSize()); >> 314: Asserts.assertEquals(116, c1.getOutputSize(100)); >> 315: var c1x = c1.exportKey("AES", new byte[1], 32).getEncoded(); > > Nit: I'd change it from var to object to make it easier to read. But it's > fine as it is if you prefer this way Thanks. I was obsessed with short var names in this test and would keep it this way. I could use explicit type or more meaningful longer names in a new test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30146#discussion_r2907183276
