On Mon, 9 Mar 2026 17:04:04 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Add export function to HPKE. New tests added. >> >> Note that this PR does not compile without >> https://github.com/openjdk/jdk/pull/18409, even if they are touching >> different files. > > test/jdk/com/sun/crypto/provider/Cipher/HPKE/KAT9180.java line 137: > >> 135: if (exports != null) { >> 136: System.err.print('x'); >> 137: var count = 0; > > What's the reason for keeping the count and printing it? Isn't it going to be > easier to debug if just for every loop at first the parameters were logged? > Count seems to be just an extra step in debugging Oh, I was just printing out "e5x6" to stderr instead of "eeeeexxxxxx". This is not really useful for a jtreg test but I use it to watch for progress when running standalone. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30146#discussion_r2907151731
