On Mon, 11 May 2026 09:46:42 GMT, Mikhail Yankelevich 
<[email protected]> wrote:

>> Adding new methods to `X509Certificate` to return `Instant` instead of 
>> `Date` as well as moving away from `Date` in internal packages wherever 
>> possible.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Mikhail Yankelevich has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   comments

One suggestion to the CSR: In the Solution or Specification section, you can 
probably add a line that we take this chance to update the ASN.1 definition in 
checkValidity() to match RFC 5280. We also remove the duplicated ASN.1 
definition in getNotBefore() and the "see getNotBefore()" lines in other 
methods, and formalize "@see #checkValidity()" as the single source of 
definition.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30047#issuecomment-4421418960

Reply via email to