On Mon, 11 May 2026 16:41:25 GMT, Sean Mullan <[email protected]> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   comments
>
> test/jdk/java/security/cert/X509Certificate/VerifyDefault.java line 1:
> 
>> 1: /*
> 
> This is an unusual test to add these changes to, since it has nothing to do 
> with the original issue that this test was created for. I'm ok with it, as 
> long as you update the `@summary`. I also think you should test the embedded 
> cert and not the `TestX509Certificate` wrapper.

This was the place the current `getNotBefore` and `getNotAfter` were tested, so 
i'd prefer to keep it here and update the summary. 

Updated the test to use `X509Certificate`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r3275638960

Reply via email to