On Mon, 11 May 2026 16:26:14 GMT, Sean Mullan <[email protected]> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   comments
>
> src/java.base/share/classes/sun/security/x509/PrivateKeyUsageExtension.java 
> line 69:
> 
>> 67: 
>> 68:     private Instant notBefore = null;
>> 69:     private Instant notAfter = null;
> 
> No need to set to `null`. Also, I think these can be `final`.

Removed setting to null. These can't be final as there is logic that requires 
them to be assigned later in     `public PrivateKeyUsageExtension(Boolean 
critical, Object value)`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r3275601718

Reply via email to