On Thu, 4 Jun 2026 21:24:32 GMT, Anthony Scarpino <[email protected]> wrote:
> I need a review to add a non-public subtype to `BinaryEncodable`, causing > `switch` statements over `BinaryEncodable` to require either a `default` > label or a `case BinaryEncodable` label. > > thanks > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/java.base/share/classes/sun/security/internal/InternalBinaryEncodable.java line 1: > 1: /* This should probably be moved to `jdk.internal.security`, just like how `MhUtil` was added to `jdk.internal.invoke` in https://github.com/openjdk/jdk/pull/20972#pullrequestreview-2301248564 instead of continuing to extend the legacy `sun.invoke` packages. Alternatively, it could be made a package private member of `java.security`. src/java.base/share/classes/sun/security/internal/InternalBinaryEncodable.java line 38: > 36: > 37: public final class InternalBinaryEncodable implements BinaryEncodable { > 38: } This should probably have a private constructor: Suggestion: public final class InternalBinaryEncodable implements BinaryEncodable { private InternalBinaryEncodable() { } } ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31391#discussion_r3368998738 PR Review Comment: https://git.openjdk.org/jdk/pull/31391#discussion_r3369000922
