On Mon, 8 Jun 2026 22:40:23 GMT, Anthony Scarpino <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/internal/InternalBinaryEncodable.java >> line 1: >> >>> 1: /* >> >> This should probably be moved to `jdk.internal.security`, just like how >> `MhUtil` was added to `jdk.internal.invoke` in >> https://github.com/openjdk/jdk/pull/20972#pullrequestreview-2301248564 >> instead of continuing to extend the legacy `sun.invoke` packages. >> >> Alternatively, it could be made a package private member of `java.security`. > > we prefer to leave it at the current location. Making it package private to `java.security` would avoid IDEs suggesting to add `InternalBinaryEncodable` to `switch` statements in `java.base` (outside of `java.security`). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31391#discussion_r3383695225
