On Mon, 13 Jul 2026 18:00:53 GMT, Artur Barashev <[email protected]> wrote:

>> Andreas Chmielewski has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Review
>
> test/jdk/sun/security/ssl/SSLAlgorithmDecomposer/BulkCipherDecomposition.java 
> line 88:
> 
>> 86:         SSLEngine engine = SSLContext.getDefault().createSSLEngine();
>> 87:         return Arrays.stream(engine.getSupportedCipherSuites())
>> 88:                 .map(CipherSuite::cipherSuite)
> 
> Do we really need `CipherSuite` dependency here? 
> `engine.getSupportedCipherSuites()` already returns the CS names we need, 
> let's just filter out `TLS_EMPTY_RENEGOTIATION_INFO_SCSV` string. Also remove 
> `@library /javax/net/ssl/TLSCommon` line above.

Same for `BulkCipherDisabledAlgorithms` test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31812#discussion_r3572992632

Reply via email to