On Mon, 13 Jul 2026 17:41:36 GMT, Andreas Chmielewski 
<[email protected]> wrote:

>> https://bugs.openjdk.org/browse/JDK-8387124
>> 
>> The test times out. This change increases the timeout based on the relative
>> execution time of DisabledAlgorithms.java.
>> 
>> Execution times on my system:
>>   DisabledAlgorithms.java            ~11 s (timeout = 480)
>>   BulkCipherDisabledAlgorithms.java  ~53 s
>> 
>> Using the same ratio would result in a timeout of approximately 2300 seconds.
>> To avoid setting such a high value, the timeout was reduced and set to 1200,
>> which should still provide sufficient margin.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andreas Chmielewski has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Review

test/jdk/sun/security/ssl/SSLAlgorithmDecomposer/BulkCipherDecomposition.java 
line 39:

> 37: import java.util.ArrayList;
> 38: import java.util.Arrays;
> 39: import java.util.List;

Nit: let's remove unused import above.

test/jdk/sun/security/ssl/SSLAlgorithmDecomposer/BulkCipherDecomposition.java 
line 88:

> 86:         SSLEngine engine = SSLContext.getDefault().createSSLEngine();
> 87:         return Arrays.stream(engine.getSupportedCipherSuites())
> 88:                 .map(CipherSuite::cipherSuite)

Do we really need `CipherSuite` dependency here? 
`engine.getSupportedCipherSuites()` already returns the CS names we need, let's 
just filter out `TLS_EMPTY_RENEGOTIATION_INFO_SCSV` string. Also remove 
`@library /javax/net/ssl/TLSCommon` line above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31812#discussion_r3572971762
PR Review Comment: https://git.openjdk.org/jdk/pull/31812#discussion_r3572985153

Reply via email to