On Tue, 14 Jul 2026 07:06:33 GMT, Andreas Chmielewski <[email protected]> wrote:
>> Same for `BulkCipherDisabledAlgorithms` test. > > I originally used CipherSuite intentionally to avoid hardcoded strings and to > reuse the existing constants. My thinking was that if a new cipher suite is > introduced in the future, references via the CipherSuite enum make such > dependencies easier to discover and update. > > That said, I agree that this test only needs the cipher suite names returned > by SSLEngine, so the additional CipherSuite dependency is not strictly > necessary. I'm also fine with removing the CipherSuite dependency if you > think the simpler approach is preferable :) So we are going to verify we have all the cipher suites in `CipherSuite` test enum, makes sense! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31812#discussion_r3579136890
