On Tue, 4 Aug 2026 14:18:43 GMT, Jamil Nimeh <[email protected]> wrote:
> Fix looks straightforward, but this means `crl` is more likely to be null. If > `getMatchingCRLs(null, null)` is called, then > `Collections.singletonList(null)` is returned. This looks a little abnormal > and I wonder if it will lead to unexpected NPE. Good catch. Returning a singleton collection containing null is indeed abnormal and fragile. > If we change the check to something like `if (crl != null && (selector == > null || selector.match(crl)))` I think we preserve the existing behavior for > all other input patterns and return the empty list for null/null input (which > is what we'd want, I think). I agree that `getMatchingCRLs()` should return an empty collection whenever crl is null. I’ve updated the condition to: `if (crl != null && (selector == null || selector.match(crl)))` The patch has been updated accordingly. Please take another look. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32164#issuecomment-5181064527
