On Tue, 4 Aug 2026 15:22:24 GMT, Guanqiang Han <[email protected]> wrote:

>> Please review this change. Thanks!
>> 
>> **Description:**
>> 
>> When an oversized CRL is fetched, the cached `crl` is cleared only when 
>> debugging is enabled, and `lastModified` is not reset.
>> 
>> **Solution:**
>> 
>> Always clear the cached `crl` and reset `lastModified` when an oversized CRL 
>> is discarded.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Guanqiang Han has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Handle null CRLs in getMatchingCRLs

src/java.base/share/classes/sun/security/provider/certpath/URICertStore.java 
line 656:

> 654:                     }
> 655:                     lastModified = 0;
> 656:                     crl = null;

I think it is better to return an empty `Collection` here instead of falling 
through and calling `getMatchingCRLs`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32164#discussion_r3761476192

Reply via email to