On Wed, 12 Aug 2026 18:57:03 GMT, Sean Mullan <[email protected]> wrote:

>> Let me take a closer look and get back to you. I feel like this is guarding 
>> against a bug in the code. A null CRL should never really be passed into 
>> `getMatchingCRLs`.
>
> I took another look and I see your point. The original condition wasn't 
> logically correct, that is a null CRL should never be wrapped into a 
> Collection. While we could probably restructure the code to not pass a null 
> CRL to `getMatchingCRLs`, it probably isn't worth it if it is not fixing an 
> existing issue.
> 
> I'd wait for Jamil to run your latest changes thru our testing again.

Thanks for taking another look. I'll wait for Jamil's testing results.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32164#discussion_r3771335081

Reply via email to