On Wed, 12 Aug 2026 07:01:30 GMT, Daniel Skantz <[email protected]> wrote:
>> Small fixups: spacing issues, typing errors, clarify return value divergence >> at their sites. Tidy up barrettReduce block comment. Testing: build / GHA >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Daniel Skantz has updated the pull request incrementally with one additional > commit since the last revision: > > param order Changes look good. Approved as `Author`. If you are curious, the methods that require canonical coefficients, e.g., `compressPoly4_5()`, would never have a caller supply an input coefficient of `q`, because prior operations, e.g., `mlKem[Subtract|Add]Poly()`, would have ensured that an input before Barrett reduction would never be `-q` by adding `q` during the respective operation. ------------- Marked as reviewed by semery (Author). PR Review: https://git.openjdk.org/jdk/pull/32295#pullrequestreview-4934223806
