On Wed, 19 Aug 2026 17:39:22 GMT, Andrew Haley <[email protected]> wrote:
>> Shawn Emery has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implement comments from theRealAph and adinn
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5070:
>
>> 5068: }
>> 5069: __ str(a[24], Address(state, 192));
>> 5070: }
>
> Suggestion:
>
> int i;
> for (i = 0; i < 24; i += 2) {
> __ stp(a[i], a[i + 1], Address(state, i * wordSize));
> }
> __ str(a[i], Address(state, i * wordSize));
Done.
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5101:
>
>> 5099: // use r3.r17,r19..r28 to keep a0..a24.
>> 5100: // a0..a24 are respective locals from SHA3.java
>> 5101: Register a[25] = {
>
> Suggestion:
>
> const Register a[25] = {
>
> And `const`ify everywhere.
Done.
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5168:
>
>> 5166: __ ldp(r25, r26, Address(sp, 64));
>> 5167: __ ldp(r27, r28, Address(sp, 80));
>> 5168: if (can_use_fp && can_use_r18) {
>
> Suggestion:
>
> pop(saved_regs, rsp);
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32049#discussion_r3819743755
PR Review Comment: https://git.openjdk.org/jdk/pull/32049#discussion_r3819746029
PR Review Comment: https://git.openjdk.org/jdk/pull/32049#discussion_r3819745061
