On Thu, 20 Aug 2026 08:56:52 GMT, Andrew Haley <[email protected]> wrote:
> This is starting to look good. A much-needed cleanup!
>
> One more thing I'd do, while I was at it. There are several instances of this
> pattern:
>
> ```
> if (!can_use_fp || !can_use_r18) {
> __ ldp(tmp3, tmp4, __ post(sp, 16));
> }
> ```
>
> which can be replaced by unconditional `push` and `pop`.
I'm concerned that the unconditional `push` & `pop` here, in that it could have
some performance impact for Linux-Neoverse systems. As this would create
artificial spillage whereas none was needed before this change.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/32049#issuecomment-5363540028
