On Thu, 20 Aug 2026 08:07:52 GMT, Shawn Emery <[email protected]> wrote:
>> This enhancement provides AArch64 GPR intrinsics for doubleKeccak(). >> Previously, only SIMD (Neon) intrinsics were implemented for doubleKeccak() >> on AArch64 systems. Performance gains for ML-KEM and ML-DSA benchmarks >> improve from 2 to 9% with the GPR intrinsics: >> >> ML-KEM decapsulation: +2-6% ops/sec >> ML-KEM encapsulation: +3-8% ops/sec >> ML-KEM key generation: +4-6% ops/sec >> >> ML-DSA signing: +2-4% ops/sec >> ML-DSA verification: +6-9% ops/sec >> ML-DSA key generation: +6-8% ops/sec >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Shawn Emery has updated the pull request incrementally with one additional > commit since the last revision: > > Implement more comments from theRealAph and adinn This is starting to look good. A much-needed cleanup! One more thing I'd do, while I was at it. There are several instances of this pattern: if (!can_use_fp || !can_use_r18) { __ ldp(tmp3, tmp4, __ post(sp, 16)); } which can be replaced by unconditional `push` and `pop`. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32049#issuecomment-5353676636
