On Thu, 6 Aug 2026 21:35:48 GMT, Valerie Peng <[email protected]> wrote:
>> Initial commit containing the public API changes and related regression >> tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > import cleanup. src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java line 60: > 58: // for including Argon2 parameters in toString() method > 59: private final transient String info; > 60: private transient Cleaner.Cleanable cleaner; Probably not necessary to mark these `transient` now that serialization is not supported. src/java.base/share/classes/com/sun/crypto/provider/Blake2b.java line 41: > 39: * @since 28 > 40: */ > 41: public final class Blake2b { Make package-private? I don't think it needs to be public. src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line 132: > 130: private static <T> T checkNonNull(T o, String name) { > 131: if (o == null) { > 132: throw new IllegalArgumentException("Argon2 " + name + I would add "parameter" after the name. Same comment on lines 141, 149, and 153. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3822296526 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3822100536 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3815355702
