On Wed, 19 Aug 2026 17:42:22 GMT, Sean Mullan <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> import cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 132:
>
>> 130: private static <T> T checkNonNull(T o, String name) {
>> 131: if (o == null) {
>> 132: throw new IllegalArgumentException("Argon2 " + name +
>
> I would add "parameter" after the name. Same comment on lines 141, 149, and
> 153.
I can do that, but then it will be like: "Argon2 parameter tag length must be
at least ...". Is this what you prefer?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4202328379
