On Fri, 21 Aug 2026 20:45:04 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> import cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 187:
>
>> 185:
>> 186: /**
>> 187: * Sets the memory cost to {@code 2}<sup>{@code mPower}</sup>
>> KiB.
>
> Just curious, why should "2" be rendered in `{@code}`? The whole thing is no
> longer a literal Java expression.
Changed.
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 194:
>
>> 192: * if {@code mPower} is less than 3 or greater than 30;
>> or if
>> 193: * {@code parallelism(p)} has already been called and
>> 194: * {@code mPower} is less than {@code 3 + ceil(log2(p))}
>
> I find it a little difficult to understand this. Can we say `and 2^mPower is
> less than 8 * p`?
Yes, to address your other comment, I removed the cross-parameter checking in
individual setter methods and only perform it when `build(..)` is called. This
simplified the javadoc for these setter methods.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4203182077
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4203177474
