On Mon, 31 Aug 2026 11:43:10 GMT, Matthew Donovan <[email protected]> wrote:

>> Hai-May Chao has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Updated tests with Matthew's comments
>
> test/jdk/sun/security/ssl/SignatureScheme/MLDSACertSelection.java line 69:
> 
>> 67: public class MLDSACertSelection extends SSLSocketTemplate {
>> 68: 
>> 69:     private final String testCase = System.getProperty("test.case");
> 
> Can you make this `static` and not duplicate it in `main`? This pattern is 
> repeated in the other tests as well.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r3901599267

Reply via email to