On Wed, 2 Sep 2026 08:41:09 GMT, Hai-May Chao <[email protected]> wrote:
>> This is to add support in SunJSSE for the TLS 1.3 ML-DSA signature schemes: >> mldsa44, mldsa65, and mldsa87. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update mldsa schemes order src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 566: > 564: continue; > 565: } > 566: } Why we didn't perform this check before for the existing signature schemes using `EdDSA` keyAlgorithm: `ED25519` and `ED448`? src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 628: > 626: } > 627: > 628: private boolean checkNamedParam() { I think `isNamedParam` or `hasNamedParam` would be a better name for this method. src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 629: > 627: > 628: private boolean checkNamedParam() { > 629: return "ML-DSA".equalsIgnoreCase(keyAlgorithm); Why we check only for `ML-DSA`? `EdDSA` also has named parameters. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r3973151118 PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r3973122796 PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r3973134521
