On Tue, 10 Nov 2026 00:18:17 GMT, Mohamed Issa <[email protected]> wrote:
>> The primary reason for this set of changes is to sanity check the >> **doubleKeccak** and **quadKeccak** methods. This includes their >> intrinsified and pure Java variants. The new JTREG source files listed below >> essentially validate return values from invoked private methods using the >> Java Reflection API. >> >> 1. `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java` >> 2. >> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/InvokeSanityTestBase.java` >> 3. >> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3ParallelIntrinsics.java` >> >> Additionally, the multi block intrinsic tests now check the correct >> **implCompressMultiBlock0** method. All modifications and tests used >> [OpenJDK v28-b22](https://github.com/openjdk/jdk/releases/tag/jdk-28%2B22) >> as the baseline build. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mohamed Issa has updated the pull request incrementally with one additional > commit since the last revision: > > Fix some more bugs and cleanup VM flag usage. src/hotspot/share/opto/c2compiler.cpp line 651: > 649: case vmIntrinsics::_quad_keccak: > 650: if (StubRoutines::quad_keccak() == nullptr) return false; > 651: break; This is out of scope of this test enhancement and should be filed/fixed separately. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4522301761
