On Tue, 10 Nov 2026 00:18:17 GMT, Mohamed Issa <[email protected]> wrote:
>> The primary reason for this set of changes is to sanity check the >> **doubleKeccak** and **quadKeccak** methods. This includes their >> intrinsified and pure Java variants. The new JTREG source files listed below >> essentially validate return values from invoked private methods using the >> Java Reflection API. >> >> 1. `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java` >> 2. >> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/InvokeSanityTestBase.java` >> 3. >> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3ParallelIntrinsics.java` >> >> Additionally, the multi block intrinsic tests now check the correct >> **implCompressMultiBlock0** method. All modifications and tests used >> [OpenJDK v28-b22](https://github.com/openjdk/jdk/releases/tag/jdk-28%2B22) >> as the baseline build. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mohamed Issa has updated the pull request incrementally with one additional > commit since the last revision: > > Fix some more bugs and cleanup VM flag usage. And on Linux x64: compiler/intrinsics/sha/sanity/TestSHA1MultiBlockIntrinsics.java -XX:UseAVX=0 -XX:UseSSE=2 ----------System.out:(2/119)---------- Verifying positive.log Intrinsic _digestBase_implCompressMB verification, is expected: true, matched: 0, suspected: 61 ----------System.err:(75/6145)---------- WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='28'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_getIntUnaligned' nodes='7'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='22'/> WARNING: Other intrinsic detected <intrinsic id='_arraycopy' nodes='89'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='16'/> WARNING: Other intrinsic detected <intrinsic id='_arraycopy' nodes='91'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='30'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_putIntUnaligned' nodes='4'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='28'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_putIntUnaligned' nodes='13'/> WARNING: Other intrinsic detected <intrinsic id='_Preconditions_checkIndex' nodes='26'/> WARNING: Other intrinsic detected <intrinsic id='_reverseBytes_i' nodes='1'/> WARNING: Other intrinsic detected <intrinsic id='_putIntUnaligned' nodes='5'/> java.lang.RuntimeException: Unexpected count of intrinsic _digestBase_implCompressMB is expected:true, matched: 0, suspected: 61 at compiler.testlibrary.intrinsics.Verifier$VerificationStrategy$2.verify(Verifier.java:75) at compiler.testlibrary.intrinsics.Verifier.verify(Verifier.java:154) at compiler.testlibrary.intrinsics.Verifier.main(Verifier.java:105) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) at java.base/java.lang.reflect.Method.invoke(Method.java:583) at com.sun.javatest.regtest.agent.MainMethodHelper.executeModernMainClass(MainMethodHelper.java:56) at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:140) at java.base/java.lang.Thread.run(Thread.java:1552) ------------- PR Comment: https://git.openjdk.org/jdk/pull/33709#issuecomment-6763377899
