On Tue, 10 Nov 2026 00:18:17 GMT, Mohamed Issa <[email protected]> wrote:
>> The primary reason for this set of changes is to sanity check the >> **doubleKeccak** and **quadKeccak** methods. This includes their >> intrinsified and pure Java variants. The new JTREG source files listed below >> essentially validate return values from invoked private methods using the >> Java Reflection API. >> >> 1. `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java` >> 2. >> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/InvokeSanityTestBase.java` >> 3. >> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3ParallelIntrinsics.java` >> >> Additionally, the multi block intrinsic tests now check the correct >> **implCompressMultiBlock0** method. All modifications and tests used >> [OpenJDK v28-b22](https://github.com/openjdk/jdk/releases/tag/jdk-28%2B22) >> as the baseline build. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mohamed Issa has updated the pull request incrementally with one additional > commit since the last revision: > > Fix some more bugs and cleanup VM flag usage. I see this failure in our testing on macosx-aarch64-debug: compiler/intrinsics/sha/sanity/TestSHA3ParallelIntrinsics.java -ea -esa -XX:CompileThreshold=100 -XX:+UnlockExperimentalVMOptions -server -XX:-TieredCompilation ----------System.out:(5/108)---------- class = sun.security.provider.SHA3Parallel method = doubleKeccak TestInvoke Error: expected = 0 actual = 1 ----------System.err:(17/1127)---------- java.lang.Exception: Exception: java.lang.Exception: TestInvoke Error at compiler.intrinsics.sha.TestInvoke.testInvoke(TestInvoke.java:98) at compiler.intrinsics.sha.sanity.InvokeSanityTestBase.test(InvokeSanityTestBase.java:81) at compiler.intrinsics.sha.sanity.TestSHA3ParallelIntrinsics.main(TestSHA3ParallelIntrinsics.java:86) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) at java.base/java.lang.reflect.Method.invoke(Method.java:583) at com.sun.javatest.regtest.agent.MainMethodHelper.executeModernMainClass(MainMethodHelper.java:56) at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:140) at java.base/java.lang.Thread.run(Thread.java:1552) Caused by: java.lang.Exception: TestInvoke Error at compiler.intrinsics.sha.TestInvoke.testInvoke(TestInvoke.java:95) ... 7 more ------------- PR Comment: https://git.openjdk.org/jdk/pull/33709#issuecomment-6762498638
