On Dec 29, 3:07 am, Iñaki Baz Castillo <[email protected]> wrote:
> El Martes, 29 de Diciembre de 2009, Jeremy Evans escribió:
>
> > Currently, the conditional is the only way to do it.  I'd consider a
> > patch to the MySQL adapter that respected a :size option for the
> > generic File type that is recognized (i.e.
> > File :doc, :size=>:medium).  The way Sequel is set up, it doesn't
> > complain if you pass unregonized options, so the option would just be
> > ignored on other database adapters.
>
> I attach a patch implementing it. It works for me.
>
> Hope it's ok. Thanks a lot.

Most of your patch is whitespace changes. :)

Also, you didn't include any specs.  :(

Other than that, it looks good, except that I would only
recognize :tiny, :medium, and :long.  You don't need :normal since
that is the default, and I'm not a fan of aliases in general
(e.g. :small and :big).

Jeremy

--

You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sequel-talk?hl=en.


Reply via email to