El Martes, 29 de Diciembre de 2009, Jeremy Evans escribió:

> Most of your patch is whitespace changes. :)

Oh no, it was git's fault, really! XD
Well, I took the original file, added my code (without adding whitespaces) and 
built the diff with "git diff".
No idea why those whitespace appeared :(


> Also, you didn't include any specs.  :(

Ok, could you please tell me how to include specs? Do you mean comments before 
the class/method to appear in RDoc?


> Other than that, it looks good, except that I would only
> recognize :tiny, :medium, and :long.  You don't need :normal since
> that is the default, and I'm not a fan of aliases in general
> (e.g. :small and :big).

Ok :)

Thanks a lot.


-- 
Iñaki Baz Castillo <[email protected]>

--

You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sequel-talk?hl=en.


Reply via email to