On Dec 29, 8:28 am, Iñaki Baz Castillo <[email protected]> wrote:
> El Martes, 29 de Diciembre de 2009, Jeremy Evans escribió:
>
> > Most of your patch is whitespace changes. :)
>
> Oh no, it was git's fault, really! XD
> Well, I took the original file, added my code (without adding whitespaces) and
> built the diff with "git diff".
> No idea why those whitespace appeared :(

Maybe your editor automatically changed the whitespace?  I'm not
sure.  Didn't you look at the patch before uploading it? :)

> > Also, you didn't include any specs.  :(
>
> Ok, could you please tell me how to include specs? Do you mean comments before
> the class/method to appear in RDoc?

No, that's documentation (which should be improved as well).

Specs are in the spec folder.  You'll want to open up spec/adapters/
mysql_spec.rb, create a table using each of the 4 :size
(:tiny, :medium, :long, and none) options for File, and check that the
four types of blobs are created.

Jeremy

--

You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sequel-talk?hl=en.


Reply via email to