Haha awesome Rob, thanks for writing code that was easy to copy-paste & modify 😄 Out of curiosity what approach are you taking to add the comments to the db in the first place? .run in migrations? this gem https://rubygems.org/gems/sequel-pg-comment? another gem? Custom code?
Thanks again On Wed, Mar 3, 2021 at 4:13 AM Rob Galanakis <[email protected]> wrote: > :michael_jackson_popcorn_gif: > > Way to go! (I added the column comment support) > > On Tuesday, March 2, 2021 at 5:09:31 PM UTC-8 [email protected] wrote: > >> Thanks Jeremy, I just opened up >> https://github.com/jeremyevans/sequel-annotate/pull/21 >> >> On Tue, Mar 2, 2021 at 2:39 PM Jeremy Evans <[email protected]> wrote: >> >>> On Tue, Mar 2, 2021 at 10:44 AM Mark Allen <[email protected]> wrote: >>> >>>> Jeremy, I noticed that column comments show up in the annotations from >>>> sequel-annotate gem which is awesome! However, table-level SQL comments do >>>> not seem to make it through to the model annotations, and I don't see any >>>> specs that include table comments either here: >>>> https://github.com/jeremyevans/sequel-annotate/blob/master/spec/sequel-annotate_spec.rb >>>> So I'm assuming it's not currently supported. >>>> >>>> Is this a feature that sequel-annotate could support? I could try >>>> implementing it and submitting a PR if you think yes, and any pointers in >>>> the right direction as always would be very helpful. >>>> >>> >>> You are correct that table comments are not currently expected to be >>> picked up. I'm open to a PR that adds support for them. I didn't author >>> the column comment support, so I don't really remember what is involved. I >>> assume a query per table to get the table comment, and if a table comment >>> exists, displaying it the annotation, maybe after the table name and before >>> the column information. >>> >>> Thanks, >>> Jeremy >>> >>> -- >>> >> You received this message because you are subscribed to a topic in the >>> Google Groups "sequel-talk" group. >>> To unsubscribe from this topic, visit >>> https://groups.google.com/d/topic/sequel-talk/EpAe_N__FeU/unsubscribe. >>> To unsubscribe from this group and all its topics, send an email to >>> [email protected]. >>> >> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/sequel-talk/CADGZSScaP9bEP09M77nKPJ_oodCZ0JgjY-rw9JFZxaBGA%3DSUnA%40mail.gmail.com >>> <https://groups.google.com/d/msgid/sequel-talk/CADGZSScaP9bEP09M77nKPJ_oodCZ0JgjY-rw9JFZxaBGA%3DSUnA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> >> -- >> >> *Mark Allen, *Vice President, Engineering, Vydia, Inc. >> >> Website: vydia.com >> >> <https://linkedin.com/in/markivanallen> >> <https://facebook.com/vydiaofficial> <https://twitter.com/vydiaofficial> >> > -- > You received this message because you are subscribed to a topic in the > Google Groups "sequel-talk" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/sequel-talk/EpAe_N__FeU/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sequel-talk/25efb43e-ec62-4e81-a2de-af37b8385e5an%40googlegroups.com > <https://groups.google.com/d/msgid/sequel-talk/25efb43e-ec62-4e81-a2de-af37b8385e5an%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- *Mark Allen, *Vice President, Engineering, Vydia, Inc. Website: vydia.com <https://linkedin.com/in/markivanallen> <https://facebook.com/vydiaofficial> <https://twitter.com/vydiaofficial> -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sequel-talk/CA%2B%2BobE9ySDGS1u922tacqfVBRPXijX_3AnQuHc5MOXuxLLFCtA%40mail.gmail.com.
