[ 
https://issues.apache.org/jira/browse/JAMES-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983327#action_12983327
 ] 

Stefano Bagnara commented on JAMES-1184:
----------------------------------------

So, here I am with the second step:

One of my principles is that an api module is justified if there are at least 2 
modules using it or if the api exposed is useful/cool enough to be used outside 
james (and in this case I would think moving to a separate project too).
So:
A) repository-api: doesn't make sense to have an api for this. IMO it contains 
simply implementation details and we should move the classes to data-library.
B) mailetcontainer-api(7) could be merged to mailetcontainer-library(16): no 
component seems to deal with mailetcontainer-api, so we don't need to expose 
them in a special module.

Then, given I don't see advantages in keeping them separated...
C) domainlist-api(3), mail-api(2), user-api(9) could be merged to data-api: I 
don't see downstream users using only one of these api and their implementation 
for something really useful outside james so I would simply follow what we did 
with the libraries and merge them into a single module.

Then a couple of minor changes:
D) mailetcontainer-api jmx subpackage: why do we need this jmx at the api 
level? I'd move the jmx stuff to the mailetcontainer-library module.
E) rename user-ldap to ldap: maybe in future someone will implement a readonly 
domainlist via ldap (so this would work like other modules: jcr,jpa,jdbc,file).

This second step reduces the number of modules from 34 to 30.
Waiting for your feedback.

> Modules consolidation
> ---------------------
>
>                 Key: JAMES-1184
>                 URL: https://issues.apache.org/jira/browse/JAMES-1184
>             Project: JAMES Server
>          Issue Type: Task
>          Components: Build System
>    Affects Versions: 3.0-M2
>            Reporter: Stefano Bagnara
>            Assignee: Stefano Bagnara
>             Fix For: 3.0-M3
>
>
> Just opening it to keep track of the proposal to the mailing list.
> ------------
> - mail-file(3)
> - mail-jcr(1)
> - mail-jdbc(3)
> - user-jpa(4)
> - user-file(2)
> - user-jcr(2)
> - user-jdbc(4)
> - domainlist-jpa(2)
> - domainlist-xml(1)
> I only see benefits and no drawbacks in consolidating the 9 modules
> above to the following 4 modules:
>  persistence-jpa(6) = user-jpa(4)+domainlist-jpa(2)
>  persistence-file(6) = user-file(2)+mail-file(3)+domainlist-xml(1)
>  persistence-jcr(3) = user-jcr(2)+mail-jcr(1)
>  persistence-jdbc(7) = user-jdbc(4)+mail-jdbc(3)
> - mail-library(1)
> - domainlist-library(2)
> - user-library(9)
> We could consolidate them into a persistence-library module (from 3 to
> 1 module).
>  persistence-library(12) =
> mail-library(1)+domainlist-library(2)+user-library(9)
> - queue-library(2)
> - queue-jms(5)
> We could merge queue-library to queue-jms (a library module makes
> sense when we do something useful.. if it is trivial stuff it can be
> duplicated or moved to the api layer).
>  queue-jms(7) = queue-jms(5)+queue-library(2)
> -------------------------
> It seems there is agreement on the merging. We still have to decide whether 
> to name the modules "persistence-${type}" or simply "${type}" (or maybe 
> "data-${type}")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to