[ 
https://issues.apache.org/jira/browse/JAMES-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefano Bagnara updated JAMES-1184:
-----------------------------------

    Attachment: graph-server-deps-edited.gif

Forgot to share another graph I made yesterday after the second step 
refactoring.

This include external jars dependencies in the chart.

It is interesting to see that our api layer have only this dependencies:
- apache-mailet
- javax.mail
- commons-logging
- commons-configuration
On the library level we add:
- protocols-api
- mailet-base
- protocols-impl
- netty
Then we have 2 shared dependencies in functions:
- jspf-resolver
- protocols-smtp
The good thing is that every other dependency is strictly isolated in a single 
"function" module and I think this was the main goal of mudules, so it seems we 
did it :-)  (I grouped dependencies with their module when they was used just 
by that module)

I hope to find some time the next weekend to put my hands on the netty stuff 
(it is one of the new things I still don't know very well): I would like to see 
if I can remove netty from the library layer and isolate it to a function 
(using composition and maybe a new api for replacing direct inheritance).

> Modules consolidation
> ---------------------
>
>                 Key: JAMES-1184
>                 URL: https://issues.apache.org/jira/browse/JAMES-1184
>             Project: JAMES Server
>          Issue Type: Task
>          Components: Build System
>    Affects Versions: 3.0-M2
>            Reporter: Stefano Bagnara
>            Assignee: Stefano Bagnara
>             Fix For: 3.0-M3
>
>         Attachments: graph-server-deps-edited.gif, graph-server-utils.gif, 
> graph-server.gif
>
>
> Just opening it to keep track of the proposal to the mailing list.
> ------------
> - mail-file(3)
> - mail-jcr(1)
> - mail-jdbc(3)
> - user-jpa(4)
> - user-file(2)
> - user-jcr(2)
> - user-jdbc(4)
> - domainlist-jpa(2)
> - domainlist-xml(1)
> I only see benefits and no drawbacks in consolidating the 9 modules
> above to the following 4 modules:
>  persistence-jpa(6) = user-jpa(4)+domainlist-jpa(2)
>  persistence-file(6) = user-file(2)+mail-file(3)+domainlist-xml(1)
>  persistence-jcr(3) = user-jcr(2)+mail-jcr(1)
>  persistence-jdbc(7) = user-jdbc(4)+mail-jdbc(3)
> - mail-library(1)
> - domainlist-library(2)
> - user-library(9)
> We could consolidate them into a persistence-library module (from 3 to
> 1 module).
>  persistence-library(12) =
> mail-library(1)+domainlist-library(2)+user-library(9)
> - queue-library(2)
> - queue-jms(5)
> We could merge queue-library to queue-jms (a library module makes
> sense when we do something useful.. if it is trivial stuff it can be
> duplicated or moved to the api layer).
>  queue-jms(7) = queue-jms(5)+queue-library(2)
> -------------------------
> It seems there is agreement on the merging. We still have to decide whether 
> to name the modules "persistence-${type}" or simply "${type}" (or maybe 
> "data-${type}")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to